Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invest all strategy #146

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix invest all strategy #146

merged 2 commits into from
Jul 21, 2023

Conversation

poliwop
Copy link
Collaborator

@poliwop poliwop commented Jul 18, 2023

No description provided.

@poliwop poliwop requested a review from jepidoptera July 18, 2023 22:06
Copy link
Contributor

@jepidoptera jepidoptera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and if it fixes the problem, may be good enough. I think there is also a change to invest_all itself that should happen, so that instead of returning a modified copy of the original state, it mutates the state. I suppose that's part of another pull request. Have you verified that this does fix the problem? It will still be working with a copy of the state, and not the original object.

@jepidoptera jepidoptera self-requested a review July 21, 2023 16:40
@poliwop poliwop merged commit 12edbd3 into main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants